Add MITL branding elements and match navigation as close as possible. #26
Conversation
There was a problem hiding this comment.
This looks fantastic. Thanks!
A couple of things I noticed:
At a window width of 670px (in Brave dev tools) the language selector dropdown starts colliding with the "MORE" menu item.
After performing a search, on the search results page, the search box and search profile selector lose their border, making them hard to pick out. There is also a grey vertical bar just to the left side of the red search button. this appears as a separator between the "X (clear search)" and the magnifying glass search button in the un-customized view
|
@adamshire123 I seem to have the search box styling fixed on that child page now. The menu wrapping was caused by my font size increase... whatever Javascript they're using to proactively hide the menu items is thrown off by the larger size of the larger text. I'm going to revert that to the original size for now. Would you mind taking another look at this when you get a chance? I'd love to hammer out any bugs, get this merged, and see how it looks with the logo swapped out before making another round of changes. |
2 participants
Why these changes are being introduced
The out of the box NDE experience doesn't align with MITL branding.
How this addresses that need
This work introduces relevant header, footer, and search components that are as close as possible to intended design system components. This includes:
Side effects of this change
Not noticed on my end, but definitely worth double-checking.
Relevant ticket(s)